Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kASLR for rk3399 u-boot #4311

Merged
merged 4 commits into from
Oct 26, 2022

Conversation

Manouchehri
Copy link
Collaborator

WIP

@Manouchehri
Copy link
Collaborator Author

Could someone with UART run kaslrseed in u-boot to see why it's failing?

Maybe @paolosabatino if you have one? =)

@paolosabatino
Copy link
Contributor

Could someone with UART run kaslrseed in u-boot to see why it's failing?

Maybe @paolosabatino if you have one? =)

I have the equipment, but unfortunately me and the equipment will be very far in the next week and can't give immediate support 😮‍💨

@igorpecovnik igorpecovnik added the Work in progress Unfinished / work in progress label Oct 22, 2022
@Manouchehri
Copy link
Collaborator Author

I have a serial console working now. It looks like u-boot still can't find the RNG, even with this patch. Trying to figure out where my mistake is..

The manual clocks screw it up, so remove those.
@Manouchehri Manouchehri marked this pull request as ready for review October 26, 2022 15:48
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Work in progress Unfinished / work in progress labels Oct 26, 2022
@igorpecovnik igorpecovnik merged commit 0d67456 into armbian:master Oct 26, 2022
@Manouchehri Manouchehri added the Work in progress Unfinished / work in progress label Oct 26, 2022
@Manouchehri
Copy link
Collaborator Author

For anyone reading this, my mistake was having the clocks manually defined in u-boot. Getting rid of those seems to have got it working.

@Tonymac32
Copy link
Member

@igorpecovnik this commit is only adding the feature to the R4S u-boot config, but attempting to use it for all boards via the shared bootscript. I've been asked what the extra boot noise is "unknown command 'kaslrseed' - try 'help'

@Manouchehri
Copy link
Collaborator Author

@Tonymac32 The correct fix is to add kASLR to those other boards. IMO the warning is a good warning, as no kASLR is not a good thing.

@Tonymac32
Copy link
Member

No disagreement from me, however upon review this should heave been requested before merge. Do you know the status of this feature on RK3328, RK3588, RK3568, etc?

@Manouchehri
Copy link
Collaborator Author

Manouchehri commented Jan 20, 2023

It was mentioned in #4306 (comment).

Ideally, this should be eventually addressed upstream in u-boot for all devices with a hardware RNG. The main motivation here is that I have some of these RK3399 devices, and was willing to test/maintain the patch.

I don't know the status of this feature on other boards, that would require users to tell us which chipset they're using when they see the warning message. (e.g. I still don't know what device you're using, other than it's probably not a R4S.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Reviewed, tested and ready for merge Work in progress Unfinished / work in progress
Development

Successfully merging this pull request may close these issues.

4 participants