Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Deprecate rk3588-legacy in favor of rk3588-vendor #6835

Open
2 of 7 tasks
Tracked by #6821
ColorfulRhino opened this issue Jun 29, 2024 · 5 comments
Open
2 of 7 tasks
Tracked by #6821

[Task]: Deprecate rk3588-legacy in favor of rk3588-vendor #6835

ColorfulRhino opened this issue Jun 29, 2024 · 5 comments
Labels
08 Milestone: Third quarter release Discussion Being discussed - Voice your opinions :) Task/To-Do Project management: To-Do or task(s) someone is working on

Comments

@ColorfulRhino
Copy link
Collaborator

ColorfulRhino commented Jun 29, 2024

With a soon-to-be-updated linux-rockchip 6.1-rkr3 kernel, it may be time to finally sunset the 5.10 legacy kernel for RK3588.
The 6.1 vendor kernel is overall just a better/more up-to-date version of the Rockchip kernel and will receive updates down the line. With the recent addition of the current kernel branch for RK3588, we currently have 5 active kernel branches for this SOC: https://github.com/armbian/build/blob/main/config/sources/families/rockchip-rk3588.conf
It's also easier for @amazingfate to maintain only one branch of the kernel.

This task/issue is a place to discuss this topic before implementation. Let's hear your opinions 😄

Task List

For marking the legacy kernel as deprecated/EOL (now):

For removing the legacy kernel as a whole (TO-DO at a later date):

  • Make legacy and vendor point to the same variables in the family config
  • Remove kernel patch folder for rk3588-legacy
  • Remove kernel config file
  • Remove traces of the legacy rk3588 kernel in the code
Copy link

Jira ticket: AR-2394

@ColorfulRhino ColorfulRhino added Discussion Being discussed - Voice your opinions :) 08 Milestone: Third quarter release labels Jun 29, 2024
@ColorfulRhino ColorfulRhino changed the title Deprecate rk3588-legacy in favor of rk3588-vendor [Task]: Deprecate rk3588-legacy in favor of rk3588-vendor Jun 29, 2024
@ColorfulRhino ColorfulRhino added the Task/To-Do Project management: To-Do or task(s) someone is working on label Jun 29, 2024
@rpardini
Copy link
Member

I've one use case for the legacy / 5.10 kernel: being able to write MAC addresses to the Realtek 2.5gbit (r8125/r8169) ethernets. See instructions at Mario's -- the program only builds and works on 5.10, not 6.1.

Otherwise, I use legacy on "production" systems -- if it is removed from Armbian, I'll be forced to userpatch the hell out of it.

@igorpecovnik
Copy link
Member

igorpecovnik commented Jun 30, 2024

We can remove it from board configs - "legacy" is anyway EOL label. And later remove source defs.

@rpardini
Copy link
Member

Yes. I'd be happy if it's removed from KERNEL_TARGETS, since we can actually build BRANCH=legacy even if it isn't listed there.

But I'd keep the family code handling it, which amounts to a 10-line block (repeated twice, just like vendor, due to the rk35xx/rockchip-rk3588(-which-is-actually-rk35xx-LINUXFAMILY) duplication crazy.

@ColorfulRhino
Copy link
Collaborator Author

ColorfulRhino commented Jun 30, 2024

Okay we can do it like that if you prefer 👍
I'll keep this task open as a reminder to finally delete legacy at some point later down the line (in some months/a year? we can see and re-evaluate in a few months).

I have updated the task list to reflect this approach. Feel free to edit it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release Discussion Being discussed - Voice your opinions :) Task/To-Do Project management: To-Do or task(s) someone is working on
Development

No branches or pull requests

3 participants