Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields gets disturbed with version 3.0.17 #1689

Closed
two-points opened this issue Dec 6, 2017 · 6 comments
Closed

Fields gets disturbed with version 3.0.17 #1689

two-points opened this issue Dec 6, 2017 · 6 comments
Milestone

Comments

@two-points
Copy link

two-points commented Dec 6, 2017

Edit: There is a problem with almost all kirki fields. styles.min.css in controls folder is missing.

Issue description:

I have used typography field in my theme. It was working fine until version 3.0.16. With version 3.0.17, its layout looks disturbed in customizer and standard fonts don't appear in the drop-down.

Screenshot on Version 3.0.16: https://imgur.com/NjdG7lc
Screenshot on Version 3.0.17: https://imgur.com/CCGRU1C

Version used:

(Did you try using the develop branch from github? There's a chance your issue has already been adressed there)
version 3.0.17

Using theme_mods or options?

theme_mods

Code to reproduce the issue (config + field(s))

Kirki::add_field( 'custompress_theme', array(
'settings' => 'body_typography',
'label' => __( 'Body Typography', 'custompress' ),
'section' => 'custom_typography',
'type' => 'typography',
'priority' => 1,
'default' => array(
'font-family' => "-apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Oxygen-Sans, Ubuntu, Cantarell, 'Helvetica Neue', sans-serif",
'variant' => 'regular',
'color' => '#606c76',
),
'output' => array(
array(
'element' => array( 'body', 'button', 'input', 'optgroup', 'select', 'textarea' ),
),
),
) );

@two-points two-points changed the title Typography field gets disturbed with version 3.0.17 Fields gets disturbed with version 3.0.17 Dec 6, 2017
@two-points
Copy link
Author

Found another issue closed with the same problem. #1687

But, even after downloading again from wordpress.org, has not solved the issue for me. I'm closing this ticket as it might get resolved in some time.

@aristath
Copy link
Contributor

aristath commented Dec 6, 2017

Check again in a couple of minutes please....

@two-points
Copy link
Author

Sure. Thank you for the awesome plugin and excellent support.

@two-points
Copy link
Author

Hello @aristath ,

Fields are getting displayed properly now. But, "Standard fonts" are missing in typography field drop-down. Google fonts are displayed properly.

Screenshot: https://imgur.com/nHAis40

What can be the cause of this issue?

aristath added a commit that referenced this issue Dec 6, 2017
@aristath aristath added this to the 3.0.18 milestone Dec 6, 2017
@aristath
Copy link
Contributor

aristath commented Dec 6, 2017

fixed in 3.0.18

@two-points
Copy link
Author

Hello @aristath ,

Thank you for the update.

Standard fonts are displayed now in the drop-down. But, we are not able to change variant of standard fonts. It works perfectly for Google fonts.

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants