Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot edit manually value in input of multicolor field #1666

Closed
tutv opened this issue Nov 22, 2017 · 1 comment
Closed

Cannot edit manually value in input of multicolor field #1666

tutv opened this issue Nov 22, 2017 · 1 comment
Milestone

Comments

@tutv
Copy link
Contributor

tutv commented Nov 22, 2017

Issue description:

I tried to add a multicolor field. I would like to edit manually but when I click to input, it hides immediately.

Screenshot

Version used:

3.0.16

Using theme_mods or options?

theme_mods

Code to reproduce the issue (config + field(s))

No config and use example code:

 Kirki::add_panel( 'panel_id', array(
        'priority'    => 10,
        'title'       => esc_attr__( 'My Panel', 'textdomain' ),
        'description' => esc_attr__( 'My panel description', 'textdomain' ),
    ) );

    Kirki::add_section( 'section_id', array(
        'title'          => esc_attr__( 'My Section', 'textdomain' ),
        'description'    => esc_attr__( 'My section description.', 'textdomain' ),
        'priority'       => 160,
        'panel' => 'panel_id'
    ) );

    Kirki::add_field( 'theme_config_id', array(
        'type'        => 'multicolor',
        'settings'    => 'my_setting',
        'label'       => esc_attr__( 'Label', 'textdomain' ),
        'section'     => 'section_id',
        'priority'    => 10,
        'choices'     => array(
            'link'    => esc_attr__( 'Color', 'textdomain' ),
            'hover'   => esc_attr__( 'Hover', 'textdomain' ),
            'active'  => esc_attr__( 'Active', 'textdomain' ),
        ),
        'default'     => array(
            'link'    => '#0088cc',
            'hover'   => '#00aaff',
            'active'  => '#00ffff',
        ),
    ) );
@tutv tutv changed the title Cannot edit value in input of multicolor field Cannot edit manually value in input of multicolor field Nov 22, 2017
@aristath aristath added this to the 3.0.17 milestone Nov 25, 2017
aristath added a commit that referenced this issue Nov 25, 2017
@aristath
Copy link
Contributor

@tutv95 Things changed a lot for colorpickers in WP 4.9 so this has to undergo a significant restructure/refactoring.
The appearance of the control has changed but it still does the same thing.
I'll go ahead and close this one for now, this will be revisited in v3.1 where we'll be refactoring all controls anyway since many things will change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants