Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography controls bug #1560

Closed
ukathemes opened this issue Oct 4, 2017 · 5 comments
Closed

Typography controls bug #1560

ukathemes opened this issue Oct 4, 2017 · 5 comments

Comments

@ukathemes
Copy link

ukathemes commented Oct 4, 2017

Hi!

There is some problen with typography field. In this example: https://github.com/aristath/_s/blob/master/inc/customizer.php#L74-L124 if lines 114-117 commented out or deleted the same sub-fields in "body_typography" field don't work correctly.

Version used: 3.0.10

Using theme_mods or options?

theme_mods

Code to reproduce the issue (config + field(s))

https://github.com/aristath/_s

@aristath
Copy link
Contributor

aristath commented Oct 4, 2017

Please elaborate.
What do you mean by "don't work correctly"?
The more details you provide the easier it will be for me to try and replicate the issue so that it can be fixed.

@ukathemes
Copy link
Author

This sub-fields don't display default values and dont save it.

https://yadi.sk/i/GLCPChA43NTTpm

If "body_typography" and "headers_typography" have the same fields, all work correctly.

https://yadi.sk/i/x5C6LIVz3NTUz2

@dariodev
Copy link

dariodev commented Oct 4, 2017

This is the same issue as in #1521 - font-size and line-height are not saved in v3.0.10, also does not work in latest develop version. Works fine in v.3.0.9.

@ukathemes
Copy link
Author

This is the same issue as in #1521 - font-size and line-height are not saved in v3.0.10, also does not work in latest develop version. Works fine in v.3.0.9.

It happens when we have more than one typography field and if they have diferent sub-fields.
Also, reset button delete font variant.

aristath added a commit that referenced this issue Oct 5, 2017
@aristath
Copy link
Contributor

aristath commented Oct 5, 2017

Thank you both for the extra details, this was just fixed.

@aristath aristath closed this as completed Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants