Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default typography values #1423

Closed
nk-o opened this issue Jun 25, 2017 · 3 comments
Closed

Default typography values #1423

nk-o opened this issue Jun 25, 2017 · 3 comments
Milestone

Comments

@nk-o
Copy link

nk-o commented Jun 25, 2017

Issue description:

When I tried to add 1 element of typography control (font-size or so), the CSS generates all available styles:
image

It is replaced my default text color from the main CSS file to #ffffff, that is not ok:
image

Also, I got this error and no auto-reload working:
image

Version used:

3.0.4 release

Using theme_mods or options?

theme_mods

Code to reproduce the issue (config + field(s))

Kirki::add_config('test', array(
    'capability' => 'edit_theme_options',
    'option_type' => 'theme_mod',
));

Kirki::add_section('typography', array(
    'title' => esc_html__('Typography', 'test'),
    'priority' => 11
));

Kirki::add_field('test', array(
    'type' => 'typography',
    'settings' => 'typography_html',
    'label' => esc_attr__('HTML', 'test'),
    'section' => 'typography',
    'default' => array(
        'font-size' => '15px'
    ),
    'priority' => 10,
    'output' => array(
        array(
            'element' => 'html',
        ),
    ),
    'transport' => 'auto'
));
aristath added a commit that referenced this issue Jun 25, 2017
@aristath
Copy link
Contributor

Fixed, can you please test using the development branch from this repository?

@nk-o
Copy link
Author

nk-o commented Jun 25, 2017

With the latest commits from the master branch it is working ok. With code from the develop branch - nothing changed.

Thank you.

@aristath
Copy link
Contributor

Yeah, I just pushed the commits to the wrong branch... fixing that as we speak. 👍

Glad it works now. Relieved actually... 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants