Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio-image labels? #1220

Closed
shelbyneilsmith opened this issue Dec 21, 2016 · 5 comments
Closed

Radio-image labels? #1220

shelbyneilsmith opened this issue Dec 21, 2016 · 5 comments
Milestone

Comments

@shelbyneilsmith
Copy link

I feel like adding labels for radio-image options would be highly useful. So, instead of just defining radio-image choices like key => url, you could have something like

key => array( label => 'label', url => 'url' )

Then it could just add a title attribute to each option's .image-clickable span element. Are there any plans for anything like this?

@shelbyneilsmith
Copy link
Author

Any thoughts on this? Seem like a relatively easy feature to implement...surely I can't be the only one that needs this..?

@aristath aristath modified the milestones: 3.0, 3.1 Apr 21, 2017
@aristath aristath modified the milestones: 3.0, 3.1 May 14, 2017
@aristath
Copy link
Contributor

Fixed.
But instead of label and url I used src and alt 'cause those are the attribules used in the image, so it made more sense that way.

@shelbyneilsmith
Copy link
Author

Fantastic! I'll update my themes asap!

@aristath
Copy link
Contributor

Keep in mind that this only works with the development branch of the plugin...
Try it and if you have any suggestions regarding the styling, let me know. Pull requests are greatly appreciated :)

@shelbyneilsmith
Copy link
Author

Yeah, I realized that as soon as I posted... may hold off on applying to themes, haha. anyway, I'll check it out and let you know if I have suggestions. Thanks for getting to this!

@aristath aristath mentioned this issue May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants