Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more than 1 variant using Typography Control #1114

Closed
chandranoor opened this issue Sep 11, 2016 · 1 comment
Closed

Add more than 1 variant using Typography Control #1114

chandranoor opened this issue Sep 11, 2016 · 1 comment

Comments

@chandranoor
Copy link

Issue description:

I wonder how to add more than 1 google fonts variant using kirki typo option?
That would be great if use multiple choices instead of dropdown option.

Version used:

(Did you try using the develop branch from github? There's a chance your issue has already been adressed there)

Using theme_mods or options?

Options

Code to reproduce the issue (config + field(s))

Kirki::add_field( 'my_config', array(
'type' => 'typography',
'settings' => 'my_setting',
'label' => esc_attr__( 'Control Label', 'kirki' ),
'section' => 'my_section',
'default' => array(
'font-family' => 'Roboto',
'variant' => 'regular',
'font-size' => '14px',
),
'output' => array(
array(
'element' => 'body',
),
),

The code above only load 1 variant.

https://fonts.google.com/specimen/Lora?selection.family=Roboto:400

maybe you can add a feature like this
example:
Kirki::add_field( 'my_config', array(
...
...
default => array(
variant => array('regular','600italic'),
)

@aristath
Copy link
Contributor

Closing as duplicate of #992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants