Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix number format issue in MIM provider #8

Merged
merged 1 commit into from
Jul 8, 2023
Merged

Fix number format issue in MIM provider #8

merged 1 commit into from
Jul 8, 2023

Conversation

raihanul-2k15
Copy link
Contributor

The Problem

Package tries to send to invalid number when user providers destination number starting with '88' and containing '88' somewhere in the number.

Example:

formatNumber('8801742433788') // 88017424337
formatNumber('8801884328812') // 880143212

After Fix

formatNumber('8801742433788') // 8801742433788
formatNumber('8801884328812') // 8801884328812

@arif98741 arif98741 added the fix label Jul 8, 2023
@arif98741 arif98741 merged commit 098dfbb into arif98741:master Jul 8, 2023
@arif98741
Copy link
Owner

arif98741 commented Jul 8, 2023 •
edited
Loading

Thanks for your time to catch the issue.
New version is released with your contribution https://github.com/arif98741/xenon/releases/tag/v1.0.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raihanul-2k15 @arif98741