Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing from YouTube does not work when a video was left unclosed #20

Closed
mikavilpas opened this issue May 10, 2021 · 2 comments
Closed

Sharing from YouTube does not work when a video was left unclosed #20

mikavilpas opened this issue May 10, 2021 · 2 comments
Assignees
@arianneorpilla
Labels
bug Something isn't working enhancement New feature or request

Comments

@mikavilpas
Copy link

How to reproduce:

  • open a YouTube video in jidoujisho
  • minimize it and open YouTube instead
  • in the YouTube app, share a video to jidoujisho
@arianneorpilla
Copy link
Owner

arianneorpilla commented May 10, 2021 •
edited
Loading

I have implemented the desired behavior in 0.16.2.

See the relevant line in the release notes:

  • Player will now appropriately change if a YouTube link is shared while another video is playing

With that, I am closing this issue.

@arianneorpilla arianneorpilla self-assigned this May 10, 2021
@arianneorpilla arianneorpilla added bug Something isn't working enhancement New feature or request labels May 10, 2021
@arianneorpilla
Copy link
Owner

There was an oversight I had to fix in 0.16.3. Please let me know if there's any more problems as I did rush this one overnight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arianneorpilla arianneorpilla

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikavilpas @arianneorpilla