Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): No redirect loop when running on root. Fixes #3967 #3968

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

thejoeejoee
Copy link
Contributor

@thejoeejoee thejoeejoee commented Nov 30, 2024

Fixes #3967.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Josef Kolář <josef.kolar@firma.seznam.cz>
@thejoeejoee thejoeejoee force-pushed the fix-dashboard-redirect-loop branch from 9ae3676 to 61d0eb6 Compare November 30, 2024 14:02
@thejoeejoee thejoeejoee changed the title fix(dashboard): No redirect loop with running on root. Fixes #3967 fix(dashboard): No redirect loop when running on root. Fixes #3967 Nov 30, 2024
@thejoeejoee thejoeejoee marked this pull request as ready for review November 30, 2024 14:13
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.70%. Comparing base (5f59344) to head (61d0eb6).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3968   +/-   ##
=======================================
  Coverage   82.69%   82.70%           
=======================================
  Files         163      163           
  Lines       22895    22895           
=======================================
+ Hits        18934    18936    +2     
+ Misses       3087     3086    -1     
+ Partials      874      873    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Published E2E Test Results

  4 files    4 suites   3h 20m 2s ⏱️
113 tests 100 ✅  7 💤  6 ❌
464 runs  424 ✅ 28 💤 12 ❌

For more details on these failures, see this check.

Results for commit 61d0eb6.

Copy link
Contributor

Published Unit Test Results

2 284 tests   2 284 ✅  2m 59s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit 61d0eb6.

@zachaller zachaller merged commit 35147d3 into argoproj:master Dec 4, 2024
28 checks passed
Rizwana777 pushed a commit to Rizwana777/argo-rollouts that referenced this pull request Dec 12, 2024
…#3967 (argoproj#3968)

fix(dashboard): no redirect loop with running on root

Signed-off-by: Josef Kolář <josef.kolar@firma.seznam.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dashboard] Empty root-path causes redirect loop
3 participants