fix(dashboard): Cleanup viewcontroller after each request. Fixes #2095 #3966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2095
Every time
GetRolloutInfo
route is called it creates a newRolloutViewController
, but the context passed into the view controller was never cancelled. This resulted in the informers never being cleaned up which manifested as a memory leak. Cancelling the view controllers context after the request has processed eliminates the "memory leak".The graph below shows our production instance (pod named
argo-rollouts-dashboard-8dfdc4bd6-vkhkp
) vs the test instance with the fix applied (pod namedargo-rollouts-dashtest
). Both instances were receiving API requests every 15seconds.Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.