Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[argo-rollouts] Ability to trust private CAs #1957

Closed
stavrospieros1 opened this issue Apr 12, 2023 · 2 comments
Closed

[argo-rollouts] Ability to trust private CAs #1957

stavrospieros1 opened this issue Apr 12, 2023 · 2 comments
Labels
argo-rollouts enhancement New feature or request good first issue Good for newcomers

Comments

@stavrospieros1
Copy link

Is your feature request related to a problem?

We need to reach out a private custom application from inside Argo Rollouts pods.
Right now when we try to reach it we receive x509: certificate signed by unknown authority
The ca is known and we just need somehow to trust it from inside Argo Rollouts.

Related helm chart

argo-rollouts

Describe the solution you'd like

I found out the following issue where a similar problem in argo-cd is solved by mounting the ca-store
argoproj/argo-cd#6477
But argo rollouts chart does not allow us to add volumes and volumeMounts
https://github.com/argoproj/argo-helm/blob/main/charts/argo-rollouts/templates/controller/deployment.yaml

So if the argo rollouts chart allows us to add volumes and volumeMounts we can address the problem for argo-rollouts too.

Of course maybe the community has a better idea.

Describe alternatives you've considered

I have not something else in mind, but any approach that could make possible to trust additional ca inside argo-rollouts is more than welcome.

Additional context

No response

@stavrospieros1 stavrospieros1 added the enhancement New feature or request label Apr 12, 2023
@jmeridth jmeridth changed the title Ability to trust private CAs inside Argo Rollouts [argo-rollouts] Ability to trust private CAs Apr 12, 2023
@jmeridth jmeridth added the good first issue Good for newcomers label Apr 12, 2023
@jmeridth
Copy link
Member

@stavrospieros1 is this similar? Was closed by #1965

@stavrospieros1
Copy link
Author

Hi @jmeridth , yes #1965 covers my request.
Thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-rollouts enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants