Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for events generated by GCP Pub/Sub and GCS (via Pub/Sub or webhooks) #45

Closed
vicaire opened this issue Jul 17, 2018 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@vicaire
Copy link

vicaire commented Jul 17, 2018

We would like support for events triggered by GCP Pub/Sub and GCS to be added.

@magaldima
Copy link
Contributor

Okay. Can you elaborate on how these signals would be configured? Do we need to add to the existing SensorSpec API? Webhooks and various Pub/Sub (streaming platforms) are already supported. Does GCP have it's own such platform?

@vicaire
Copy link
Author

vicaire commented Jul 18, 2018

Hi magaldima@, here are some more details:

  • Yes, GCP has its own pub/sub platform: https://cloud.google.com/pubsub/
  • For GCS, the webhook support looks great! GCS can also forward notifications to Pub/Sub. Pub/Sub is probably a more important use case as it has the advantage of not requiring the user to expose a public IP address to receive the webhook notification.
  • What is missing is then the ability to extract information from the Pub/Sub message or Webhook notification (the URI of the created object) and pass this as a parameter to a workflow. If the issue "Add filters for signals #26" solves the filtering problem in a generic enough way, that could be a solution to this issue.

For reference, the format of the GCS notification is straightforward json (https://cloud.google.com/storage/docs/object-change-notification).

@magaldima
Copy link
Contributor

@vicaire take a look at: #49 . This is an effort to make building signals easier especially for stream (pub/sub) services. I think your second point may be able to be solved through a custom GCP Pub/Sub signal microservice. And yes, your third point essentially boils down to filters.

Let me know if you have time to build out a custom GCP Pub/Sub signal. I would be more than happy to help out.

@magaldima
Copy link
Contributor

@vicaire since latest 0.5-beta1 release, you can now extract information/fields from a signal's event payload and pass it to a workflow. See the quickstart guide on an easy example to run.

As per a custom signal for the GCP pub/sub platform, I'll add this to the v1.0.0 milestone and work on this when I get some free time.

@magaldima magaldima added enhancement New feature or request new labels Jul 27, 2018
@magaldima magaldima added this to the v1.0.0 milestone Jul 27, 2018
@vicaire
Copy link
Author

vicaire commented Jul 27, 2018

Thanks magaldima@, that looks great.

@VaibhavPage
Copy link
Contributor

#176

@vicaire
Copy link
Author

vicaire commented Feb 28, 2019

Thank you! This is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants