Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for sensor #20

Closed
VaibhavPage opened this issue Jun 9, 2018 · 0 comments · Fixed by #71
Closed

Add validation for sensor #20

VaibhavPage opened this issue Jun 9, 2018 · 0 comments · Fixed by #71
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@VaibhavPage
Copy link
Contributor

VaibhavPage commented Jun 9, 2018

Is your feature request related to a problem? Please describe.
Currently there is no validation for sensors other than checking that each signal type is supported.

Describe the solution you'd like
we need to add validation for the following rules:

  • each signal only defines one of: (stream, artifact, calendar, resource, webhook)
  • all resource object trigger parameters reference a signal that's defined
  • all signal time filters specify a start time before stop time and a stop time after current time (allow nil values here to represent +/- infinity?)
  • calendar signals all have either a schedule or interval defined and the recurrence patterns are okay
@VaibhavPage VaibhavPage added the enhancement New feature or request label Jun 9, 2018
@VaibhavPage VaibhavPage changed the title Add Validate method for signal Add validation for signal Jun 10, 2018
@magaldima magaldima added the new label Jun 13, 2018
@magaldima magaldima added this to the v1.0.0 milestone Jun 13, 2018
@magaldima magaldima self-assigned this Jun 27, 2018
@magaldima magaldima changed the title Add validation for signal Add validation for sensor Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants