Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): no hyphen for "create job" action + nice icon (#14776) #14777

Merged
merged 6 commits into from
Jul 31, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/operator-manual/upgrading/2.7-2.8.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ p, role:action-runner, applications, action/apps/Deployment/restart, *, allow
# If you don't want to grant the new permissions, don't include the following lines
p, role:action-runner, applications, action/argoproj.io/WorkflowTemplate/create-workflow, *, allow
p, role:action-runner, applications, action/argoproj.io/CronWorkflow/create-workflow, *, allow
p, role:action-runner, applications, action/batch/CronJob/create-job, *, allow
p, role:action-runner, applications, action/batch/CronJob/create job, *, allow
```

## Change default file open mode
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
actionTests:
- action: create-job
- action: create job
inputPath: testdata/cronjob.yaml
expectedOutputPath: testdata/job.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
actions = {}
actions["create-job"] = {}
actions["create job"] = {}
return actions
2 changes: 1 addition & 1 deletion server/application/application_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2100,7 +2100,7 @@ func TestRunNewStyleResourceAction(t *testing.T) {
version := "v1"
resourceName := "my-cron-job"
namespace := testNamespace
action := "create-job"
action := "create job"
uid := "1"

resources := []appsv1.ResourceStatus{{
Expand Down