Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typo #14412

Merged
merged 1 commit into from
Jul 8, 2023
Merged

docs: fix typo #14412

merged 1 commit into from
Jul 8, 2023

Conversation

yukinakanaka
Copy link
Contributor

@yukinakanaka yukinakanaka commented Jul 8, 2023 •
edited
Loading

Fixed seven typos in documentations.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@yukinakanaka
docs: fix typo
ca9aefb 
Signed-off-by: yukinakanaka <yuki.nakamura@mapbox.com>
crenshaw-dev
crenshaw-dev approved these changes Jul 8, 2023
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @yukinakanaka!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) July 8, 2023 20:54
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.8

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.7

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.6

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.5

@crenshaw-dev crenshaw-dev merged commit 987615f into argoproj:master Jul 8, 2023
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 8, 2023
@yukinakanaka
docs: fix typo (#14412)
bced74c 
Signed-off-by: yukinakanaka <yuki.nakamura@mapbox.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jul 8, 2023
Merged
@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error 987615f4b0d9fe2c4088a401dcac3a20e77484d8 into temp-cherry-pick-5550c7-release-2.7

@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error 987615f4b0d9fe2c4088a401dcac3a20e77484d8 into temp-cherry-pick-5550c7-release-2.6

@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error 987615f4b0d9fe2c4088a401dcac3a20e77484d8 into temp-cherry-pick-5550c7-release-2.5

jannfis pushed a commit that referenced this pull request Jul 10, 2023
@gcp-cherry-pick-bot @yukinakanaka
docs: fix typo (#14412) (#14413)
ca03596 
Signed-off-by: yukinakanaka <yuki.nakamura@mapbox.com>
Co-authored-by: Yuki Nakamura <yuki.nakamura@mapbox.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
@yukinakanaka
docs: fix typo (argoproj#14412)
a8e661e 
Signed-off-by: yukinakanaka <yuki.nakamura@mapbox.com>
@suzaku suzaku mentioned this pull request Aug 15, 2023
Closed
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@yukinakanaka @tesla59
docs: fix typo (argoproj#14412)
fa1ef42 
Signed-off-by: yukinakanaka <yuki.nakamura@mapbox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yukinakanaka @crenshaw-dev