Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource out of sync / diff issue with HPA metric sort #12605

Closed
otherguy opened this issue Feb 24, 2023 · 4 comments
Closed

Resource out of sync / diff issue with HPA metric sort #12605

otherguy opened this issue Feb 24, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@otherguy
Copy link

It seems ArgoCD doesn't ignore the sorting of metrics in HPAs:

CleanShot 2023-02-24 at 17 02 37@2x

Unfortunately, it's being rendered by a 3rd party Helm chart (https://artifacthub.io/packages/helm/ingress-nginx/ingress-nginx), so the resource is always out of sync.

To reproduce, these are the values:

controller: 
  autoscaling:
    enabled: true
    minReplicas: 5
    maxReplicas: 15
    targetCPUUtilizationPercentage: 50
    targetMemoryUtilizationPercentage: 50
  autoscalingTemplate:
    - type: Pods
      pods:
        metric:
          name: prometheus.googleapis.com|nginx_ingress_controller_nginx_process_connections|gauge
          selector:
            matchLabels:
              metric.labels.controller_namespace: nginx
        target:
          type: AverageValue
          averageValue: 5000
@otherguy otherguy added the bug Something isn't working label Feb 24, 2023
@OmerKahani
Copy link
Contributor

Seems like a dup #7846

@otherguy
Copy link
Author

Not exactly, because here it’s about the HPA and #7846 talks about resources in deployments.

It is definitely the same problem but depending on how the fix looks like, it might be worth it to keep this one open.

@shinebayar-g
Copy link

Dup #1079

@otherguy
Copy link
Author

otherguy commented Mar 6, 2024

@shinebayar-g seems that way. Closing because #1079 provides a resolution.

@otherguy otherguy closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants