From 957f705b7872f2f2e7a9312493952e1792937999 Mon Sep 17 00:00:00 2001 From: Jonathan West Date: Thu, 29 Oct 2020 09:03:01 -0400 Subject: [PATCH] fix: Repo-server has silent unmarshalling errors leading to empty applications (#4423) --- reposerver/cache/cache_test.go | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/reposerver/cache/cache_test.go b/reposerver/cache/cache_test.go index 372e3cf81e59c..bc60fb2c5feba 100644 --- a/reposerver/cache/cache_test.go +++ b/reposerver/cache/cache_test.go @@ -129,7 +129,7 @@ func TestCachedManifestResponse_HashBehavior(t *testing.T) { inMemCache := cacheutil.NewInMemoryCache(1 * time.Hour) - thing := NewCache( + repoCache := NewCache( cacheutil.NewCache(inMemCache), 1*time.Minute, ) @@ -151,7 +151,10 @@ func TestCachedManifestResponse_HashBehavior(t *testing.T) { NumberOfCachedResponsesReturned: 0, NumberOfConsecutiveFailures: 0, } - thing.SetManifests(response.Revision, appSrc, response.Namespace, appKey, appValue, store) + err := repoCache.SetManifests(response.Revision, appSrc, response.Namespace, appKey, appValue, store) + if err != nil { + t.Fatal(err) + } // Get the cache entry of the set value directly from the in memory cache, and check the values var cacheKey string @@ -179,7 +182,7 @@ func TestCachedManifestResponse_HashBehavior(t *testing.T) { // Retrieve the value using 'GetManifests' and confirm it works retrievedVal := &CachedManifestResponse{} - err := thing.GetManifests(response.Revision, appSrc, response.Namespace, appKey, appValue, retrievedVal) + err = repoCache.GetManifests(response.Revision, appSrc, response.Namespace, appKey, appValue, retrievedVal) if err != nil { t.Fatal(err) } @@ -202,7 +205,7 @@ func TestCachedManifestResponse_HashBehavior(t *testing.T) { // Retrieve the value using GetManifests and confirm it returns a cache miss retrievedVal = &CachedManifestResponse{} - err = thing.GetManifests(response.Revision, appSrc, response.Namespace, appKey, appValue, retrievedVal) + err = repoCache.GetManifests(response.Revision, appSrc, response.Namespace, appKey, appValue, retrievedVal) assert.True(t, err == cacheutil.ErrCacheMiss)