From 80a17433fd3aa7a50a82f87859983c14d126394d Mon Sep 17 00:00:00 2001 From: Dhruv Kelawala Date: Fri, 31 Mar 2023 12:35:31 +0530 Subject: [PATCH 1/4] fix: try fixing chromatic --- .github/workflows/chromatic.yml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/chromatic.yml b/.github/workflows/chromatic.yml index 4459bfab2..80e8f7b22 100644 --- a/.github/workflows/chromatic.yml +++ b/.github/workflows/chromatic.yml @@ -12,16 +12,21 @@ jobs: # Job steps if: github.actor != 'dependabot[bot]' steps: - - uses: actions/checkout@v1 + # 👇 Version 2 of the action + - name: Checkout repository + uses: actions/checkout@v2 + with: + fetch-depth: 0 # 👈 Required to retrieve git history - name: Install dependencies run: yarn setup # 👇 Adds Chromatic as a step in the workflow - - name: Change to storybook directory - run: cd packages/storybook - name: Publish to Chromatic uses: chromaui/action@v1 # Chromatic GitHub Action options with: # 👇 Chromatic projectToken, refer to the manage page to obtain it. projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }} - storybookBaseDir: packages/storybook + workingDir: packages/storybook + autoAcceptChanges: true + # 👇 Enables Chromatic in debug mode. TODO: Remove before merging + debug: true From 93e5aa6d92ace405ef91c962a23184154d7ac05d Mon Sep 17 00:00:00 2001 From: Dhruv Kelawala Date: Fri, 31 Mar 2023 14:23:03 +0530 Subject: [PATCH 2/4] feat: add test-storybook --- packages/storybook/package.json | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/packages/storybook/package.json b/packages/storybook/package.json index 794f52e2c..d07e2830d 100644 --- a/packages/storybook/package.json +++ b/packages/storybook/package.json @@ -14,6 +14,7 @@ "@storybook/builder-webpack5": "^6.5.9", "@storybook/manager-webpack5": "^6.5.9", "@storybook/react": "^6.5.9", + "@storybook/test-runner": "^0.9.4", "@storybook/testing-library": "^0.0.13", "@types/react": "^18.0.0", "@types/react-dom": "^18.0.0", @@ -23,6 +24,7 @@ "lodash-es": "^4.17.21", "react": "^18.0.0", "react-dom": "^18.0.0", + "sinon-chrome": "^3.0.1", "starknet": "^4.21.0", "storybook-addon-swc": "^1.1.7", "typescript": "^4.9.4" @@ -31,6 +33,11 @@ "storybook": "start-storybook -p 6006", "lint": "eslint . --cache --ext .ts,.tsx", "build-storybook": "build-storybook", + "test-storybook": "test-storybook", "chromatic": "chromatic --exit-zero-on-changes --exit-once-uploaded" + }, + "dependencies": { + "@types/webextension-polyfill": "^0.10.0", + "webextension-polyfill": "^0.10.0" } } From 1ba772924300f796a9c8dd6fe60b56532dc52d3b Mon Sep 17 00:00:00 2001 From: Dhruv Kelawala Date: Fri, 31 Mar 2023 14:47:18 +0530 Subject: [PATCH 3/4] fix: remove chromatic --- .github/workflows/chromatic.yml | 32 -------------------------------- packages/storybook/package.json | 6 ------ 2 files changed, 38 deletions(-) delete mode 100644 .github/workflows/chromatic.yml diff --git a/.github/workflows/chromatic.yml b/.github/workflows/chromatic.yml deleted file mode 100644 index 80e8f7b22..000000000 --- a/.github/workflows/chromatic.yml +++ /dev/null @@ -1,32 +0,0 @@ -# Workflow name -name: "Chromatic" - -# Event for the workflow -on: push - -# List of jobs -jobs: - chromatic-deployment: - # Operating System - runs-on: ubuntu-latest - # Job steps - if: github.actor != 'dependabot[bot]' - steps: - # 👇 Version 2 of the action - - name: Checkout repository - uses: actions/checkout@v2 - with: - fetch-depth: 0 # 👈 Required to retrieve git history - - name: Install dependencies - run: yarn setup - # 👇 Adds Chromatic as a step in the workflow - - name: Publish to Chromatic - uses: chromaui/action@v1 - # Chromatic GitHub Action options - with: - # 👇 Chromatic projectToken, refer to the manage page to obtain it. - projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }} - workingDir: packages/storybook - autoAcceptChanges: true - # 👇 Enables Chromatic in debug mode. TODO: Remove before merging - debug: true diff --git a/packages/storybook/package.json b/packages/storybook/package.json index d07e2830d..d9b48108a 100644 --- a/packages/storybook/package.json +++ b/packages/storybook/package.json @@ -14,7 +14,6 @@ "@storybook/builder-webpack5": "^6.5.9", "@storybook/manager-webpack5": "^6.5.9", "@storybook/react": "^6.5.9", - "@storybook/test-runner": "^0.9.4", "@storybook/testing-library": "^0.0.13", "@types/react": "^18.0.0", "@types/react-dom": "^18.0.0", @@ -24,7 +23,6 @@ "lodash-es": "^4.17.21", "react": "^18.0.0", "react-dom": "^18.0.0", - "sinon-chrome": "^3.0.1", "starknet": "^4.21.0", "storybook-addon-swc": "^1.1.7", "typescript": "^4.9.4" @@ -35,9 +33,5 @@ "build-storybook": "build-storybook", "test-storybook": "test-storybook", "chromatic": "chromatic --exit-zero-on-changes --exit-once-uploaded" - }, - "dependencies": { - "@types/webextension-polyfill": "^0.10.0", - "webextension-polyfill": "^0.10.0" } } From bbea297966f1e13d73609633d8f3fe4c6b708294 Mon Sep 17 00:00:00 2001 From: Simon Heys Date: Fri, 31 Mar 2023 14:08:55 +0100 Subject: [PATCH 4/4] Update packages/storybook/package.json --- packages/storybook/package.json | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/storybook/package.json b/packages/storybook/package.json index d9b48108a..794f52e2c 100644 --- a/packages/storybook/package.json +++ b/packages/storybook/package.json @@ -31,7 +31,6 @@ "storybook": "start-storybook -p 6006", "lint": "eslint . --cache --ext .ts,.tsx", "build-storybook": "build-storybook", - "test-storybook": "test-storybook", "chromatic": "chromatic --exit-zero-on-changes --exit-once-uploaded" } }