You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The output variable mat_name in app.read_dot is having incorrect values assigned to it. The test suite is failing due to this. See this excerpt of test_read_dot:
============================================== FAILURES ===============================================
____________________________________________ test_read_dot ____________________________________________
def test_read_dot():
burnable_mat, paths = app.read_dot(dot_input)
> assert burnable_mat == 'fuel'
E AssertionError: assert 'MultiDiGraph... and 13 edges' == 'fuel'
E - fuel
E + MultiDiGraph named 'fuel' with 13 nodes and 13 edges
test_app.py:60: AssertionError
This may be related to the failure of the other two failing tests, both of which throw errors during execution of app.reprocessing:
FAILED test_app.py::test_reprocessing - UnboundLocalError: local variable 'divisor' referenced befor...
FAILED test_app.py::test_refill - UnboundLocalError: local variable 'divisor' referenced before assi...
Inspecting the app.reprocessing function, we can find the following loop, within which lies an if-statement that only executes if the material name (mname) is fuel.
.
.
.
for mname in prcs.keys(): # iterate over materials
waste[mname] = {}
forked_mat[mname] = []
inmass[mname] = float(mat[mname].mass)
print("Material mass before reprocessing %f g" % inmass[mname])
if mname == 'fuel' and mat_name_dot == 'fuel':
w = 'waste_'
ctr = 0
for path in paths:
forked_mat[mname].append(copy.deepcopy(mat[mname]))
print("Material mass %f" % mat[mname].mass)
for p in path:
# Calculate fraction of the flow going to the process p
divisor = float(prcs[mname][p].mass_flowrate /
prcs[mname]['core_outlet'].mass_flowrate)
.
.
.
It is possible that fixing the bug with the first failing test will resolve the other two tests failing. We may need to create a separate issue for the other two tests.
Either way, this issue can be closed when the bug in mat_name has been fixed.
The text was updated successfully, but these errors were encountered:
The output variable
mat_name
inapp.read_dot
is having incorrect values assigned to it. The test suite is failing due to this. See this excerpt oftest_read_dot
:This may be related to the failure of the other two failing tests, both of which throw errors during execution of
app.reprocessing
:Inspecting the
app.reprocessing
function, we can find the following loop, within which lies anif
-statement that only executes if the material name (mname
) isfuel
.It is possible that fixing the bug with the first failing test will resolve the other two tests failing. We may need to create a separate issue for the other two tests.
Either way, this issue can be closed when the bug in
mat_name
has been fixed.The text was updated successfully, but these errors were encountered: