Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong flashmode report #16280

Merged
merged 1 commit into from
Aug 21, 2022
Merged

fix wrong flashmode report #16280

merged 1 commit into from
Aug 21, 2022

Conversation

Staars
Copy link
Contributor

@Staars Staars commented Aug 21, 2022

Description:

ATM Tasmota reports the flash mode of the first boot loader, which might be changed later in the boot process.
This uses the same method as in the bootloader_esp32.cfrom the ESP-IDF and updates the value.
In the future this might be handled differently from Espressif's side by storing this value at boot time in a global struct.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.4.1
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@Jason2866 Jason2866 self-requested a review August 21, 2022 19:22
@Jason2866
Copy link
Collaborator

Tested and verified working, nice!

@arendst arendst merged commit 810eb2e into arendst:development Aug 21, 2022
@Jason2866 Jason2866 mentioned this pull request Aug 22, 2022
6 tasks
@Staars Staars deleted the flash_mode branch September 4, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants