Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate compiler warnings for unused parameter. #508

Open
habazut opened this issue Oct 25, 2022 · 2 comments · May be fixed by #474, #484, #476, #487 or #456
Open

Eliminate compiler warnings for unused parameter. #508

habazut opened this issue Oct 25, 2022 · 2 comments · May be fixed by #474, #484, #476, #487 or #456
Labels

Comments

@habazut
Copy link

habazut commented Oct 25, 2022

/home/haba/.arduino15/packages/arduino/hardware/avr/1.8.5/cores/arduino/new.cpp: In function 'void* operator new(std::size_t, std::nothrow_t)':
/home/haba/.arduino15/packages/arduino/hardware/avr/1.8.5/cores/arduino/new.cpp:59:60: warning: unused parameter 'tag' [-Wunused-parameter]
 void * operator new(std::size_t size, const std::nothrow_t tag) noexcept {
                                                            ^~~
/home/haba/.arduino15/packages/arduino/hardware/avr/1.8.5/cores/arduino/new.cpp: In function 'void* operator new [](std::size_t, const std::nothrow_t&)':
/home/haba/.arduino15/packages/arduino/hardware/avr/1.8.5/cores/arduino/new.cpp:68:63: warning: unused parameter 'tag' [-Wunused-parameter]
 void * operator new[](std::size_t size, const std::nothrow_t& tag) noexcept {
                                                               ^~~
/home/haba/.arduino15/packages/arduino/hardware/avr/1.8.5/cores/arduino/new.cpp: In function 'void operator delete(void*, const std::nothrow_t&)':
/home/haba/.arduino15/packages/arduino/hardware/avr/1.8.5/cores/arduino/new.cpp:103:55: warning: unused parameter 'tag' [-Wunused-parameter]
 void operator delete(void* ptr, const std::nothrow_t& tag) noexcept {
                                                       ^~~
/home/haba/.arduino15/packages/arduino/hardware/avr/1.8.5/cores/arduino/new.cpp: In function 'void operator delete [](void*, const std::nothrow_t&)':
/home/haba/.arduino15/packages/arduino/hardware/avr/1.8.5/cores/arduino/new.cpp:106:57: warning: unused parameter 'tag' [-Wunused-parameter]
 void operator delete[](void* ptr, const std::nothrow_t& tag) noexcept {

Just fix. with a void (tag); With -Werror it won't compile at all.
Regards,
Harald.

@matthijskooijman
Copy link
Collaborator

There are already a number of PRs for this, I would prefer merging #487 to fix this.

@per1234 per1234 linked a pull request Jun 9, 2024 that will close this issue
@noisymime
Copy link

Is there any hope of getting one of the multiple PRs that resolve this annoyance pulled in?

The PRs are very low impact/risk, it really would be nice to have this cleaned up.

@arduino arduino locked as too heated and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.