Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protected access or getters for fields 'card', 'volume' and 'root' #133

Open
F-Schmidt99 opened this issue Apr 14, 2023 · 1 comment
Open

Protected access or getters for fields 'card', 'volume' and 'root' #133

F-Schmidt99 opened this issue Apr 14, 2023 · 1 comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@F-Schmidt99
Copy link

Please either change the visibility of the fields in the title to protected or implement getters returning references to the according object variables. This would allow further inheritance and an efficient way to display SD card details and use the same object to also read/write to SD.

With the current implementation, one has to set up an Sd2Card object just to obtain the type (and other card information) and then an additional SD object, which has an Sd2Card field. This does not make much sense.
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Apr 14, 2023
@leftCoast
Copy link

I'll do it. I want this for my stuff anyway.

-jim lee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@leftCoast @per1234 @F-Schmidt99