Allow IEnumResolver values to be number type

Author: tgriesser

CHANGELOG.md

@@ -5,6 +5,7 @@
 * Added GraphQL Subscriptions support for schema stitching and `makeRemoteExecutableSchema` [PR #563](https://github.com/apollographql/graphql-tools/pull/563)
 * Make `apollo-link` a direct dependency [PR #561](https://github.com/apollographql/graphql-tools/pull/561)
 * Update tests to use `graphql-js@0.12` docstring format [PR #559](https://github.com/apollographql/graphql-tools/pull/559)
+* IEnumResolver value can be a `number` type
 
 ### v2.15.0
 

src/Interfaces.ts

@@ -49,7 +49,7 @@ export type ITypeDefinitions = ITypedef | ITypedef[];
 export type IResolverObject = {
   [key: string]: IFieldResolver<any, any> | IResolverOptions;
 };
-export type IEnumResolver = { [key: string]: string };
+export type IEnumResolver = { [key: string]: string | number };
 export interface IResolvers {
   [key: string]:
     | (() => any)

src/test/testMergeSchemas.ts

@@ -68,12 +68,20 @@ let enumTest = `
     RED
   }
 
+  """
+  A type that uses an Enum with a numeric constant.
+  """
+  enum NumericEnum {
+    TEST
+  }
+
   schema {
     query: Query
   }
 
   type Query {
     color: Color
+    numericEnum: NumericEnum
   }
 `;
 
@@ -157,12 +165,18 @@ if (process.env.GRAPHQL_VERSION === '^0.11') {
       RED
     }
 
+    # A type that uses an Enum with a numeric constant.
+    enum NumericEnum {
+      TEST
+    }
+
     schema {
       query: Query
     }
 
     type Query {
       color: Color
+      numericEnum: NumericEnum
     }
   `;
 
@@ -232,6 +246,9 @@ testCombinations.forEach(async combination => {
             parseValue: value => value,
             parseLiteral: () => null,
           }),
+          NumericEnum: {
+            TEST: 1
+          },
           Color: {
             RED: '#EA3232',
           },
@@ -287,6 +304,9 @@ testCombinations.forEach(async combination => {
             color() {
               return '#EA3232';
             },
+            numericEnum() {
+              return 1;
+            },
             delegateInterfaceTest(parent, args, context, info) {
               return info.mergeInfo.delegate(
                 'query',
@@ -449,10 +469,16 @@ testCombinations.forEach(async combination => {
             Color: {
               RED: '#EA3232',
             },
+            NumericEnum: {
+              TEST: 1
+            },
             Query: {
               color() {
                 return '#EA3232';
               },
+              numericEnum() {
+                return 1;
+              },
             },
           },
         });
@@ -461,6 +487,7 @@ testCombinations.forEach(async combination => {
           `
             query {
               color
+              numericEnum
             }
           `,
         );
@@ -470,13 +497,15 @@ testCombinations.forEach(async combination => {
           `
             query {
               color
+              numericEnum
             }
           `,
         );
 
         expect(enumResult).to.deep.equal({
           data: {
             color: 'RED',
+            numericEnum: 'TEST'
           },
         });
         expect(mergedResult).to.deep.equal(enumResult);
@@ -1556,6 +1585,10 @@ bookingById(id: $b1) {
           'A type that uses an Enum.',
         );
 
+        expect(mergedSchema.getType('NumericEnum').description).to.equal(
+          'A type that uses an Enum with a numeric constant.',
+        );
+
         expect(mergedSchema.getType('LinkType').description).to.equal(
           'A new type linking the Property type.',
         );