Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of a zip file with no files or folders in it never triggers on 'close' #57

Closed
saadtazi opened this issue Jan 12, 2014 · 3 comments

Comments

@saadtazi
Copy link

Hi,
I am not sure if it is a bug or expected behaviour in 0.5, but the following code behaves differently in 0.4 and 0.5.0:

var fs = require('fs'),
    archiver = require('archiver');

function go() {

  var zipStream = fs.createWriteStream('./profile.zip'),
    archive = archiver('zip', { forceUTC: true });

  zipStream.on('close', function() {
  console.log('ok, created');
  });
  archive.pipe(zipStream);

  archive.finalize();
}

go();

In 0.4, on 'close' is called, but not with 0.5. Note that the zip is created.

(I know that creating an empty zip file seems weird... It's just a test scenario actually)

@ctalkington
Copy link
Member

noted. will review first chance.

@ctalkington
Copy link
Member

v0.5.1 has been published. let me know if that doesn't fix it.

@saadtazi
Copy link
Author

It is fixed! Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants