From a48e8d72bcadbb8d5e9c683a55ec0163ba7ecb65 Mon Sep 17 00:00:00 2001 From: Yi Cheng <74173148+iycheng@users.noreply.github.com> Date: Wed, 4 Jan 2023 14:17:04 -0800 Subject: [PATCH] Revert "[Core] RetryObjectInPlasmaErrors tries to fetch all objects, not just ready ones." (#31445) This reverts commit 77c9df33033ddd5da2f0885aa57e98fb6b0934d4. --- src/ray/core_worker/core_worker.cc | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/src/ray/core_worker/core_worker.cc b/src/ray/core_worker/core_worker.cc index 9f6a05c2d9153..7bf26d56c9ad3 100644 --- a/src/ray/core_worker/core_worker.cc +++ b/src/ray/core_worker/core_worker.cc @@ -1338,11 +1338,20 @@ void RetryObjectInPlasmaErrors(std::shared_ptr &memory_st for (auto iter = memory_object_ids.begin(); iter != memory_object_ids.end();) { auto current = iter++; const auto &mem_id = *current; - auto found = memory_store->GetIfExists(mem_id); - if (found != nullptr && found->IsInPlasmaError()) { - plasma_object_ids.insert(mem_id); - ready.erase(mem_id); - memory_object_ids.erase(current); + auto ready_iter = ready.find(mem_id); + if (ready_iter != ready.end()) { + std::vector> found; + RAY_CHECK_OK(memory_store->Get({mem_id}, + /*num_objects=*/1, + /*timeout=*/0, + worker_context, + /*remote_after_get=*/false, + &found)); + if (found.size() == 1 && found[0]->IsInPlasmaError()) { + plasma_object_ids.insert(mem_id); + ready.erase(ready_iter); + memory_object_ids.erase(current); + } } } }