Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong requeue order test #10

Open
erfan-mehraban opened this issue Apr 4, 2019 · 3 comments
Open

Wrong requeue order test #10

erfan-mehraban opened this issue Apr 4, 2019 · 3 comments

Comments

@erfan-mehraban
Copy link

erfan-mehraban commented Apr 4, 2019

It seems checking requeue order has logical problem.

s.Equal(messages[2].Message.Body, (<-delivery).Message.Body)

If we consume after publishing queue is like (front of queue) 1 2 3 (back of queue), requeue in order of 3 2 1 should results in this way:

requeue item queue
3 3
2 2 3
1 1 2 3

But this function test it in wrong order. (3 2 1)

@arcana261
Copy link
Owner

@erfan-mehraban You're right.. we should have prioritized items based on their ID's when we re queued. But I'm afraid it's too late to change that behavior :'(

@erfan-mehraban
Copy link
Author

@arcana261 Can we correct the test on PR?

@arcana261
Copy link
Owner

Yup do as you please :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants