Can't create node

[loa]

Using LTS Jenkins ver. 1.532.1 installed by rpm on CentOS 6.4

jenkins_api_client.git on fa7a2ea

ruby scripts/login_with_irb.rb

puts @client.job.list(".*")

puts @client.node.create_dump_slave(
  :name => "slave1",
  :slave_host => "10.10.10.10",
  :private_key_file => "/root/.ssh/id_rsa",
  :executors => 10,
  :labels => "slave, ruby"
)

ruby scripts/login_with_irb.rb
logged-in to the Jenkins API, use the '@client' variable to use the client
irb(main):001:0> puts @client.job.list(".*")
I, [2014-02-06T15:18:16.314955 #47425]  INFO -- : Obtaining jobs matching filter '.*'
I, [2014-02-06T15:18:16.315061 #47425]  INFO -- : GET /api/json
whoami
=> nil
irb(main):002:0> puts @client.node.create_dump_slave(
irb(main):003:1*   :name => "slave1",
irb(main):004:1*   :slave_host => "10.10.10.10",
irb(main):005:1*   :private_key_file => "/root/.ssh/id_rsa",
irb(main):006:1*   :executors => 10,
irb(main):007:1*   :labels => "slave, ruby"
irb(main):008:1> )
I, [2014-02-06T15:18:22.079072 #47425]  INFO -- : Creating a dump slave 'slave1'
I, [2014-02-06T15:18:22.079319 #47425]  INFO -- : GET /api/json
I, [2014-02-06T15:18:22.085380 #47425]  INFO -- : POST /computer/doCreateItem
E, [2014-02-06T15:18:22.099554 #47425] ERROR -- : JenkinsApi::Exceptions::InternalServerError: Internel Server Error. Perhaps the in-memory configuration Jenkins is different from the disk configuration. Please try to reload the configuration
JenkinsApi::Exceptions::InternalServerError: Internel Server Error. Perhaps the in-memory configuration Jenkins is different from the disk configuration. Please try to reload the configuration
    from /Users/loa/workspace/github/jenkins_api_client/lib/jenkins_api_client/client.rb:721:in `handle_exception'
    from /Users/loa/workspace/github/jenkins_api_client/lib/jenkins_api_client/client.rb:351:in `api_post_request'
    from /Users/loa/workspace/github/jenkins_api_client/lib/jenkins_api_client/node.rb:175:in `create_dump_slave'
    from (irb):2
irb(main):009:0>

[arangamani]

Would it make sense to have this as credentials_id to be consistent with the rest of the variable naming in this method?

[loa]

Ofc, totally missed this since we modified this in a rush to get it working with a PoC. How stupid of me to not see this pattern.

Anything else?

I will make the necessary changes tomorrow

[arangamani]

Nope, that's the only thing I can see. I'll go ahead and merge it once that is done. Thanks!

[loa]

Fixed!

Hoping for a new gem release soon!

[arangamani]

I didn't mean to change all occurrences of credentialsId to credentials_id. I believe this should be

"credentialsId" => params[:credentials_id]

or else jenkins wouldn't be able to recognize it. What I meant is that Jenkins uses the Java notation for attribute names and we wanted to keep it in Ruby style and then passing it correctly when passing it to Jenkins remote API. Is that clear?

Also if you could test it once, I would really appreciate it.

[loa]

Done and tested.

Tested with irb and works perfectly!

[arangamani]

Awesome.
On a related note, if you do a lot of ruby development, try out pry instead of irb and you will love it.

[arangamani]

Version 1.0.0.beta.4 is now pushed to rubygems.