Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error message when attempting to withdraw from an org without permission #520

Closed
john-light opened this issue Dec 1, 2018 · 6 comments
Labels

Comments

@john-light
Copy link
Contributor

john-light commented Dec 1, 2018

If an account attempts a withdraw from the Finance app of an organization without the permissions to do so directly or by vote, the withdraw window closes without giving the user an indication as to why the withdraw isn't going through.

@john-light
Copy link
Contributor Author

john-light commented Dec 1, 2018

Could be shown in the notification panel: #117

@sohkai
Copy link
Contributor

sohkai commented Dec 1, 2018

@john-light The panel should definitely show up with a "you can't perform this action".

@sohkai sohkai added bug and removed enhancement labels Dec 1, 2018
@sohkai
Copy link
Contributor

sohkai commented Dec 2, 2018

@john-light Ahh, actually reading this again, is this more about optimistic UI / notifying users that their transfer is "in progress" (in another app) rather than a user not having permissions at all?

@john-light
Copy link
Contributor Author

@sohkai no, I am referring to the case where the user has no permission path to complete the transfer.

@sohkai
Copy link
Contributor

sohkai commented Feb 18, 2019

Most likely related to aragon/aragon.js#235

@sohkai
Copy link
Contributor

sohkai commented Apr 17, 2019

Closed by aragon/aragon.js#285.

@sohkai sohkai closed this as completed Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants