Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent, Finance, Tokens: update forms with 'max' button #1301

Closed
sohkai opened this issue Feb 10, 2020 · 2 comments · Fixed by aragon/aragon-apps#1130
Closed

Agent, Finance, Tokens: update forms with 'max' button #1301

sohkai opened this issue Feb 10, 2020 · 2 comments · Fixed by aragon/aragon-apps#1130

Comments

@sohkai
Copy link
Contributor

sohkai commented Feb 10, 2020

All numerical token balance inputs should have a 'max' button applied to them.


In some instances, people may want to deposit/withdraw the entire balance of a certain token in Finance (eg. performing the Sai to Dai migration).

Having a 'max amount' button (as almost all exchanges do to create orders or withdraw funds) is useful not only to prevent mistakes (see image below) but also to allow to wipe the balance of a certain token down to the last decimal (which we don't show in the UI).

 2019-11-25 at 7 12 54 AM

@sohkai sohkai changed the title Tokens, Finance: update forms with 'max' button Agent, Finance, Tokens: update forms with 'max' button Mar 19, 2020
@JuanCarlosFrutos
Copy link

Hi, I'm new here 😄 , I would like to fix this issue to know the project.

If I understand the architecture, the pull request is in aragon/aragon-apps repository.

The task consists of adding a button on all numerical token balance inputs to select max amount available. The change affects apps agent, finance and token manager.

Is there any design? or could it be something like this?

image

I should assign me the issue or something like that or it's not necessary.

Thanks in advice.

@sohkai
Copy link
Contributor Author

sohkai commented Apr 12, 2020

Thanks @JuanCarlosFrutos!

If I understand the architecture, the pull request is in aragon/aragon-apps repository.
The task consists of adding a button on all numerical token balance inputs to select max amount available. The change affects apps agent, finance and token manager.

Yes, that is correct!

I should assign me the issue or something like that or it's not necessary.

Don't worry about not assigning it!

Is there any design?

We have this same pattern in the Court Dashboard:

Screen Shot 2020-04-12 at 7 36 44 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants