Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payroll: Add reentrancy guard to transfers loop #759

Closed
facuspagnuolo opened this issue Apr 4, 2019 · 0 comments · Fixed by #778
Closed

Payroll: Add reentrancy guard to transfers loop #759

facuspagnuolo opened this issue Apr 4, 2019 · 0 comments · Fixed by #778

Comments

@facuspagnuolo
Copy link
Contributor

From @sohkai (see here)

We should add a reentrancy guard to this function and Payroll.determineAllocation() (or perhaps all the functions with the employeeMatches modifier).
Right now, with ETH, you can re-enter into Payroll.determineAllocation() and modify your allocation so that a later token becomes 100% of your allocation. The worse case of this is if you set ETH to 100%, and then upon paying ETH, your contract re-enters into Payroll.determineAllocation() and sets a later token to be 100%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant