Tests: fix tests after istanbul hardfork

[sohkai]

It appears quite a few of our contract tests are now failing due to the Istanbul hardfork, most likely due to gas amounts when transferring ETH.

[sohkai]

Just realized we can most likely fix this in one go by updating the aragonOS dependency.

[bingen]

I'm afraid we have a problem with Finance fallback:
https://github.com/aragon/aragon-apps/blob/buidler-migration/buidler-apps/finance/contracts/Finance.sol#L154
@ajsantander realized while testing with buidler that this test is not passing even with @aragon/os 4.3.0:
https://github.com/aragon/aragon-apps/blob/buidler-migration/buidler-apps/finance/test/finance.js#L997
Should we try to optimize that one too, like we did with Proxy one?

[eternauta1337]

I can confirm that Finance's "can recover ETH using AragonApp#transferToVault" test FAILS with a clean clone, but if the fork is set to "constantinople" in test-helpers/ganachel-cli.sh, it PASSES.

[bingen]

Should we try to optimize that one too, like we did with Proxy one?

I see that fallback is already spending way more, so I don't think it's worth it.

[sohkai]

I see that fallback is already spending way more, so I don't think it's worth it.

This fallback was not particularly intended to be used with a send() or transfer() from a contract (as it does a number of calls and logs); contracts should be using deposit() instead.

[sohkai]

Closing for https://github.com/aragon/aragon-apps/issues/1111—we will investigate and fix issues there.