Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the UI classes contain as much logic as they do? #35

Open
stevenpitts opened this issue May 23, 2019 · 2 comments
Open

Should the UI classes contain as much logic as they do? #35

stevenpitts opened this issue May 23, 2019 · 2 comments
Labels
cleanup old code that is either unused or not up to standards question Further information is requested
Milestone

Comments

@stevenpitts
Copy link
Collaborator

stevenpitts commented May 23, 2019

Currently, a lot of the logic is being performed in the UI classes, like HyperdomeClient.
The issues with this:

  • Tests will be more difficult to run
  • UI changes could break logic
  • Feels like poor programming

I think we should keep the logic in HyperdomeClient, but move the UI aspects to a new class.
Do you agree?

@stevenpitts stevenpitts added the question Further information is requested label May 23, 2019
@stevenpitts
Copy link
Collaborator Author

stevenpitts commented May 23, 2019

Hmm, I may be overthinking this; looking at it again, there's not too much logic in there.
Edit: I'm not. But the issue is more with separation of class UIs and logic; for example; the Server object is located in the "add_server_dialog" file.

@arades79 arades79 added the cleanup old code that is either unused or not up to standards label Feb 17, 2020
@arades79
Copy link
Owner

I would like to at some point re-do the UI using QML or some other more self contained Qt code, exposing the interface in such a way that a sort of MVC paradigm can be used to organize the code. The models can then be moved up to the common code base between server and client.

@arades79 arades79 added this to the 0.3 release milestone Apr 18, 2020
@arades79 arades79 modified the milestones: 0.3 release, API version 1 Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup old code that is either unused or not up to standards question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants