Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear queue after disconnect #170

Closed
aquelemiguel opened this issue Mar 12, 2022 · 6 comments · Fixed by #178
Closed

Clear queue after disconnect #170

aquelemiguel opened this issue Mar 12, 2022 · 6 comments · Fixed by #178
Assignees
Labels
🐤 good first issue Good for newcomers 🔧 improvement General improvements to existing features

Comments

@aquelemiguel
Copy link
Owner

Rationale

The bot preserves its queue even if disconnected. This shouldn't happen because it leads to confusing situations like the bot being summoned already playing a track that was enqueued in the day before.

Description

After leaving a voice channel (in all cases, be it a manual, an idle or a /leave disconnect), the queue should be cleared.

@aquelemiguel aquelemiguel added 🐤 good first issue Good for newcomers 🔧 improvement General improvements to existing features labels Mar 12, 2022
@afonsojramos
Copy link
Collaborator

afonsojramos commented Mar 16, 2022

This only happens in a manual or a /leave disconnect, right? Since the idle only happens when nothing is playing, or did I misunderstand from the last PR #176?

@aquelemiguel
Copy link
Owner Author

AFAIK no disconnects are clearing the queue, so even if you queue a track, pause it and either have it idle disconnect or do it manually, when you re-summon it, the track will stay there. #176 is just ensuring the auto-disconnect works, not that the queue is getting flushed.

@afonsojramos
Copy link
Collaborator

What I meant is that it would never auto disconnect if it was playing music, but indeed if it is on pause it does retain the queue...

Food for thought, if someone accidentally disconnects the bot and quickly summon it back, should it retain the queue?

@aquelemiguel
Copy link
Owner Author

Good question, I don't really know? I guess for consistency, yeah?

@afonsojramos
Copy link
Collaborator

I'll take it as a "yeah it should clear the queue", even though the question was the other way around 😅

The only reference to disconnects in Serenity's documentation has been this, which I'm not sure if it applies.

@aquelemiguel
Copy link
Owner Author

Yeah, my bad, I got it backwards. I probably think it should clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐤 good first issue Good for newcomers 🔧 improvement General improvements to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants