Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(misconf): change default ACL of digitalocean_spaces_bucket to private #7577

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix(misconf): change default ACL of digitalocean_spaces_bucket to private #7577

merged 1 commit into from
Oct 17, 2024

Conversation

nikpivkin
Copy link
Contributor

Description

The acl attribute of the digitalocean_spaces_bucket resource is set to private by default.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin
fix(misconf): change default ACL of digitalocean_spaces_bucket to pri…
d61d7ac 
…vate

Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@nikpivkin nikpivkin marked this pull request as ready for review September 24, 2024 03:46
@nikpivkin nikpivkin requested a review from simar7 as a code owner September 24, 2024 03:46
@simar7 simar7 added this pull request to the merge queue Sep 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 24, 2024
@simar7 simar7 added this pull request to the merge queue Oct 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2024
@nikpivkin nikpivkin added this pull request to the merge queue Oct 17, 2024
Merged via the queue into aquasecurity:main with commit 9da84f5 Oct 17, 2024
12 checks passed
@nikpivkin nikpivkin deleted the do-buckets branch October 17, 2024 04:02
@aqua-bot aqua-bot mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikpivkin @simar7