Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dotnet): show nuget package dir not found log only when checking nuget packages #7194

Merged

Conversation

DmitriyLewen
Copy link
Contributor

Description

Currently we always show log that nuget package dir was not found :

➜  trivy -d image alpine
...
2024-07-19T14:31:41+06:00	DEBUG	[nuget] The nuget packages directory couldn't be found. License search 
...
2024-07-19T14:31:44+06:00	INFO	Number of language-specific files	num=0

But we need to show this log only when checking nuget files.

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Jul 19, 2024
@DmitriyLewen DmitriyLewen changed the title refactor: nuget package dir not found log to PostAnalyze function fix(dotnet): don't always show nuget package dir not found log Jul 19, 2024
@DmitriyLewen DmitriyLewen changed the title fix(dotnet): don't always show nuget package dir not found log fix(dotnet): show nuget package dir not found log only when checking nuget packages Jul 19, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review July 22, 2024 05:55
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner July 22, 2024 05:55
@knqyf263 knqyf263 enabled auto-merge July 25, 2024 15:33
@knqyf263 knqyf263 added this pull request to the merge queue Jul 25, 2024
Merged via the queue into aquasecurity:main with commit d76feba Jul 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants