fix(misconf): parsing numbers without fraction as int #6834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikpivkin
changed the title
simar7
reviewed
Jun 4, 2024
Comment on lines
+30
to
+47
|
|
||
| var inner parameterInner | ||
|
|
||
| if err := node.Decode(&inner); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // jfather parses Number without fraction as int64 | ||
| // https://github.com/liamg/jfather/blob/4ef05d70c05af167226d3333a4ec7d8ac3c9c281/parse_number.go#L33-L42 | ||
| switch v := inner.Default.(type) { | ||
| case int64: | ||
| inner.Default = int(v) | ||
| default: | ||
| inner.Default = v | ||
| } | ||
|
|
||
| p.inner = inner | ||
| return nil |
There was a problem hiding this comment.
Should we extract this into a function? Looks like there are other callsites like this one:
There was a problem hiding this comment.
The resource does not store a primitive value. This conversion is needed for the parameter and property of the resource.
simar7
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
jfatherparses Number without fractional part as int64, but in our types we use int, which causes type casting error.{ "AWSTemplateFormatVersion": "2010-09-09", "Parameters": { "ContainerMemory": { "Type": "Number", "Default": 512 } }, "Resources": { "TaskDefinition": { "Type": "AWS::ECS::TaskDefinition", "Properties": { "ContainerDefinitions": [ { "Memory": { "Ref": "ContainerMemory" } } ] } } } }Checklist