Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): allow an user defined existing secret #2586

Closed
cebidhem opened this issue Jul 25, 2022 · 0 comments · Fixed by #2587
Closed

feat(helm): allow an user defined existing secret #2586

cebidhem opened this issue Jul 25, 2022 · 0 comments · Fixed by #2587
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@cebidhem
Copy link
Contributor

cebidhem commented Jul 25, 2022

Hey there,

We are using Trivy for a long time in our CI, but we recently decided to give a try to the Trivy Operator, and therefore we want to deploy Trivy as a server first.
Looking at the Helm chart, all secrets must be defined as values in order to get consumed by the statefulset. It would be nice to have a way to define a secret created outside of the chart (we're using external-secrets but it could be something else).

I will submit a PR on this since I haven't seen any, and this should be pretty quick to do.

Let me know if it was on purpose, I'll close.

@cebidhem cebidhem added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 25, 2022
@cebidhem cebidhem changed the title feat(helm): allow an user defined existng secret feat(helm): allow an user defined existing secret Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant