Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "Caching Scan Results by Image Reference" #668

Closed
neiser opened this issue Nov 9, 2022 · 12 comments · Fixed by #1606
Closed

Implement "Caching Scan Results by Image Reference" #668

neiser opened this issue Nov 9, 2022 · 12 comments · Fixed by #1606

Comments

@neiser
Copy link

neiser commented Nov 9, 2022

I'm interested in the status of the document Caching Scan Results by Image Reference, as my team would really appreciate such a feature being implemented. The document reads as if there was already some implementation attempt for the operator code here, but I can't find any pull request or reference in the document to that code. I also checked in the original starboard repo and only found a similar document.

Telling from the git history, maybe @NissesSenap or @danielpacak can comment how far implementation-wise this feature is? Also, maybe @chen-keinan knows? I hope it's ok that I mention you guys directly.

Any pointer is appreciated, and if you don't have any objections, I could try and start implementation of this feature on my own.

@NissesSenap
Copy link
Contributor

@neiser I started looking in to it in the starboard project but I haven't been active in the aquasecurity project in a long time so I can't remember to be honest.

I know that @danielpacak started on a PR before he stopped and instead wrote a design document that I gave some feedback on: aquasecurity/starboard#740.

But I don't think anything was done after that but as I said I haven't been active in trivy-operator project.
Here @chen-keinan could give some insight.

I would love to see the feature and If you have time to look at it I think go for it :).

@neiser
Copy link
Author

neiser commented Nov 9, 2022

@NissesSenap Thanks for that super quick reply!

@chen-keinan
Copy link
Contributor

chen-keinan commented Nov 9, 2022

@neiser this could be a very good feature and go for it 🚀 few points :

  • TTL - today each report has by default TTL (24h , configurable) , I think will be good to keep it for vulnerability cluster reports (avoid false negative)
  • GC - not sure if it is a must as we have TTL but today each report own by one resource
  • it will be great to make it configurable

@neiser neiser changed the title Status of "Caching Scan Results by Image Reference" Implement "Caching Scan Results by Image Reference" Nov 18, 2022
@neiser
Copy link
Author

neiser commented Nov 18, 2022

I've updated the issue title to reflect that we should/can implement this feature.

@github-actions
Copy link

This issue is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Jan 18, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2023
@chen-keinan chen-keinan reopened this Feb 7, 2023
@chen-keinan chen-keinan removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Feb 7, 2023
@github-actions
Copy link

github-actions bot commented Apr 9, 2023

This issue is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Apr 9, 2023
@sathieu
Copy link

sathieu commented Apr 9, 2023

not stale.

@chen-keinan Please add the relevant label to prevent this issue to be marked as stale in the future 🙏.

@chen-keinan chen-keinan removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Apr 9, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This issue is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Jun 9, 2023
@sathieu
Copy link

sathieu commented Jun 9, 2023

still not stale.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Jun 10, 2023
@github-actions
Copy link

This issue is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Aug 10, 2023
@chen-keinan chen-keinan removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Aug 10, 2023
@github-actions
Copy link

This issue is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Oct 10, 2023
@sathieu
Copy link

sathieu commented Oct 10, 2023

This would still be useful.

@chen-keinan chen-keinan removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants