Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/s3tests-runner.sh : export CONTAINER_EXTRA_PARAMS #475

Merged
merged 2 commits into from
Apr 25, 2023
Merged

ci/s3tests-runner.sh : export CONTAINER_EXTRA_PARAMS #475

merged 2 commits into from
Apr 25, 2023

Conversation

0xavi0
Copy link
Contributor

@0xavi0 0xavi0 commented Apr 25, 2023 •
edited
Loading

Lifecycle tests are not working because the CONTAINER_EXTRA_PARAMS variable is not exported when running gnu parallel.

We need that variable because it passes --rgw-lc-debug-interval when life cycle tests are enabled (they are enabled by default)

It also adds the LIFE_CYCLE_INTERNAL_PARAM variable as that one is needed when not running s3tests with the container option.

Fixes: https://github.com/aquarist-labs/s3gw/issues/474

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • CHANGELOG.md has been updated should there be relevant changes in this PR.

@0xavi0 0xavi0 added kind/bug Something isn't working area/CI Continuous Integration labels Apr 25, 2023
@0xavi0 0xavi0 added this to the v0.15.0 milestone Apr 25, 2023
@0xavi0 0xavi0 requested a review from m-ildefons April 25, 2023 13:33
@0xavi0 0xavi0 self-assigned this Apr 25, 2023
@0xavi0 0xavi0 mentioned this pull request Apr 25, 2023
Merged
11 tasks
m-ildefons
m-ildefons suggested changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@m-ildefons m-ildefons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was LIFE_CYCLE_INTERNAL_PARAM left out on purpose?

tools/tests/s3tests-runner.sh Show resolved Hide resolved
@0xavi0
ci/s3tests-runner.sh : export CONTAINER_EXTRA_PARAMS and
94d512a 
LIFE_CYCLE_INTERVAL_PARAM

Fixes: https://github.com/aquarist-labs/s3gw/issues/474

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
@0xavi0 0xavi0 force-pushed the ci-s3tests-runner-export branch from 3db96f4 to 94d512a Compare April 25, 2023 13:45
@0xavi0 0xavi0 requested a review from m-ildefons April 25, 2023 13:46
m-ildefons
m-ildefons previously approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@m-ildefons m-ildefons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xavi0
ci: checkout HEAD for ceph repo
9b21dbc 
Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
@0xavi0 0xavi0 requested a review from m-ildefons April 25, 2023 14:25
m-ildefons
m-ildefons approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@m-ildefons m-ildefons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm not too sure about checking out the ceph repo in the directory where the submodule should live, but that shouldn't give us too much trouble for now.

@0xavi0 0xavi0 merged commit e8e594b into s3gw-tech:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-ildefons m-ildefons m-ildefons approved these changes

Assignees

@0xavi0 0xavi0

Labels
area/CI Continuous Integration kind/bug Something isn't working
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.

[BUG] s3tests-runner.sh is not exporting CONTAINER_EXTRA_PARAMS
2 participants
@0xavi0 @m-ildefons