Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix s3test runner script #353

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

m-ildefons
Copy link
Contributor

Make the s3tests runner script automatically choose podman or docker or abort if neither can be found. This is avoids problems in GitHub runners when only docker is available or on openSUSE developer environment where maybe podman is preferred.

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • CHANGELOG.md has been updated should there be relevant changes in this PR.

Make the s3tests runner script automatically choose podman or docker or
abort if neither can be found. This is avoids problems in GitHub runners
when only docker is available or on openSUSE developer environment where
maybe podman is preferred.

Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
@m-ildefons m-ildefons requested a review from 0xavi0 February 21, 2023 10:59
@m-ildefons m-ildefons self-assigned this Feb 21, 2023
@m-ildefons m-ildefons added this to the v0.13.0 milestone Feb 21, 2023
@m-ildefons m-ildefons added area/CI Continuous Integration area/tests Related to tests and testing labels Feb 21, 2023
@m-ildefons m-ildefons merged commit 5d9b32b into s3gw-tech:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration area/tests Related to tests and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants