Update documentation for default-user S3 credentials #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: https://github.com/aquarist-labs/s3gw/issues/303 Signed-off-by: Giuseppe Baccini <giuseppe.baccini@suse.com>
giubacc
force-pushed
the
default-s3-creds
branch
from
5958a54 to
ba78fd9
Compare
Add information on how to obtain the randomly generated access key and secret key, should the user not have provided them. Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
m-ildefons
suggested changes
Jan 13, 2023
There was a problem hiding this comment.
Thanks 👍 this looks good.
I'm missing information on how to obtain the randomly generated secrets though.
See: giubacc#1
docs: fixup default s3 creds
merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/aquarist-labs/s3gw/issues/303
Signed-off-by: Giuseppe Baccini giuseppe.baccini@suse.com
Checklist before requesting a review