Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy install modifies checksums #1599

Closed
suzuki-shunsuke opened this issue Jan 31, 2023 · 1 comment · Fixed by #1600
Closed

lazy install modifies checksums #1599

suzuki-shunsuke opened this issue Jan 31, 2023 · 1 comment · Fixed by #1600
Labels
bug Something isn't working checksum verification

Comments

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Jan 31, 2023

aqua version

Please use the latest version.

$ aqua -v
aqua version 1.32.1 (cf4612b3dd6ff2bbb57dee9305fb08a4c3c442a8)

Environment

  • OS (Windows, Linux, macOS, etc): macOS
  • CPU Architecture (amd64, arm64, etc): arm64

Overview

How to reproduce

  • aqua.yaml
  • executed command and output

aqua.yaml should be not partial but complete configuration.
Please remove unneeded configuration to reproduce the issue.

aqua.yaml

checksum:
  enabled: true
registries:
- type: standard
  ref: v3.126.0
packages:
- name: goreleaser/goreleaser@v1.15.0

Generate aqua-checksums.json by aqua update-checksum.

$ aqua update-checksum
$ cp aqua-checksums.json aqua-checksums.json.bak

Run a command.

$ goreleaser --help
INFO[0000] download and unarchive the package            aqua_version=1.32.1 env=darwin/arm64 exe_name=goreleaser exe_path=/Users/s-b-suzuki/.local/share/aquaproj-aqua/pkgs/github_release/github.com/goreleaser/goreleaser/v1.15.0/goreleaser_Darwin_all.tar.gz/goreleaser package=goreleaser/goreleaser package_name=goreleaser/goreleaser package_version=v1.15.0 program=aqua registry=standard

Then aqua-checksums.json is modified.

$ diff aqua-checksums.json aqua-checksums.json.bak 
5c5
<       "checksum": "348ED1199A5D4248E8588A3051382C5DADD5B46E75D508837D33360652045BFE",
---
>       "checksum": "348ed1199a5d4248e8588a3051382c5dadd5b46e75d508837d33360652045bfe",

aqua-checksums.json

{
  "checksums": [
    {
      "id": "github_release/github.com/goreleaser/goreleaser/v1.15.0/goreleaser_Darwin_all.tar.gz",
      "checksum": "348ed1199a5d4248e8588a3051382c5dadd5b46e75d508837d33360652045bfe",
      "algorithm": "sha256"
    },
    {
      "id": "github_release/github.com/goreleaser/goreleaser/v1.15.0/goreleaser_Linux_arm64.tar.gz",
      "checksum": "7bc2f36d29c0ab493e0a24225a6cc8eb01142fbfa3ee6947aef9c3dc48a251a8",
      "algorithm": "sha256"
    },
    {
      "id": "github_release/github.com/goreleaser/goreleaser/v1.15.0/goreleaser_Linux_x86_64.tar.gz",
      "checksum": "0cc69ee51335d1e5391298a8474c5731f608ed9e03a18c6747efe5d5e2dd4f41",
      "algorithm": "sha256"
    },
    {
      "id": "github_release/github.com/goreleaser/goreleaser/v1.15.0/goreleaser_Windows_arm64.zip",
      "checksum": "307f6c3467aa4fe68e89db8ff4500816bcc331afac9f55ff4cf1582e988b0d2e",
      "algorithm": "sha256"
    },
    {
      "id": "github_release/github.com/goreleaser/goreleaser/v1.15.0/goreleaser_Windows_x86_64.zip",
      "checksum": "77280b6bdfb637263209b3e507cc486b85bd0950d527e0deb6b9248e568b7829",
      "algorithm": "sha256"
    },
    {
      "id": "registries/github_content/github.com/aquaproj/aqua-registry/v3.126.0/registry.yaml",
      "checksum": "c422babb50605f3063bc07ca2cb2a19a80fd71064acc4c26ab520353d015a5e940615f754a1c46a9166600aa18dea6029210ea081d66c6ce05793b432b652d96",
      "algorithm": "sha512"
    }
  ]
}

Debug Output

Please set the environment variable AQUA_LOG_LEVEL=debug and run aqua and tell us the debug output.

$ 

Expected Behaviour

aqua-checksums.json isn't modified.

Actual Behaviour

aqua-checksums.json is modified.

Important Factoids

References

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working checksum verification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant