Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added signup login page #1387

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

added signup login page #1387

wants to merge 2 commits into from

Conversation

Nishakulkarni06
Copy link
Contributor

@Nishakulkarni06 Nishakulkarni06 commented Dec 22, 2024 •
edited by apu52
Loading

Title and Issue number

Title : Added Signup Login Page

Issue No. :#1386

Close #1386

Tech Stack : HTML,CSS,JS

Type of PR

  • Feature enhancement
  • Documentation update

Video (mandatory)

Uploading METAVERSE and 5 more pages - Profile 1 - Microsoft​ Edge 2024-12-22 19-48-20.mp4…

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas
  • I have gone through the contributing.md file before contributing
  • I have Starred the Repository.

Checklist:(In case of Adding New WEB3 project only)

  • I have made my Commits(of new project) under the Projects folder
  • I have created a helpful and easy to understand README.md
  • i have added the image of my project under asstes/img folder

Additional context (Mandatory )

Are you contributing under any Open-source programme?

  • I'm a KWOC 2024 contributor

@github-actions GitHub Actions
Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@netlify Netlify
Copy link

netlify bot commented Dec 22, 2024 •
edited
Loading

✅ Deploy Preview for cute-quokka-b093d8 ready!

Name Link
🔨 Latest commit e79cf9d
🔍 Latest deploy log https://app.netlify.com/sites/cute-quokka-b093d8/deploys/6783f89567848c0008b14673
😎 Deploy Preview https://deploy-preview-1387--cute-quokka-b093d8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

apu52
apu52 requested changes Dec 27, 2024
View reviewed changes
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nishakulkarni06 the whole design & the functionalities are well defined , but try to make a button in the navbar like login & the after user clicks on it try to make a separate login page for it & after login redirect the user in the home page ,

& also try to make the login page UI more compatible with the website

@apu52
Copy link
Owner

apu52 commented Dec 27, 2024

@Nishakulkarni06 if u will need any type of help in this feature adding feel free to reach out to me

@apu52 apu52 added the help wanted Extra attention is needed label Dec 27, 2024
@Nishakulkarni06
Copy link
Contributor Author

ok

@Nishakulkarni06
Copy link
Contributor Author

But the thing is Home page is accessible only after login so should i display like circle in profile in navbar?

@apu52
Copy link
Owner

apu52 commented Jan 11, 2025

But the thing is Home page is accessible only after login so should i display like circle in profile in navbar?

yess u can

@Nishakulkarni06
Copy link
Contributor Author

@apu52 I have made changes .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apu52 apu52 apu52 requested changes

Assignees

@Nishakulkarni06 Nishakulkarni06

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add Signup Login Page
2 participants
@Nishakulkarni06 @apu52