-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aptos.getAccountModules() #576
Labels
bug
Something isn't working
Comments
gregnazario
added a commit
that referenced
this issue
Nov 14, 2024
gregnazario
added a commit
that referenced
this issue
Nov 14, 2024
2 tasks
Yeah, looks like a bug. Actually amazed it hadn't been hit until now. Offset is actually a long input, and not just a number to start with, so the PR attached will fix this and the documentation |
gregnazario
added a commit
that referenced
this issue
Jan 7, 2025
gregnazario
added a commit
that referenced
this issue
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Bug Description
When I use this SDK to build React Front-end , I invoked the function below .
How to reproduce
Code snippet to reproduce
Stack trace / error message
So I checked network records .
The api request payload is like ( This is how the SDK translates the aptos.getAccountModules() api to do )
https://api.testnet.aptoslabs.com/v1/accounts/0xf4fd53f1334877ef7aae3241ba87708bf38c618aaa2a22f09e84720fab3328ee/modules?start=11&limit=10
Notice the query params, is start , not offset
so I change the link like this to try
https://api.testnet.aptoslabs.com/v1/accounts/0xf4fd53f1334877ef7aae3241ba87708bf38c618aaa2a22f09e84720fab3328ee/modules?offset=11&limit=10
it worked.
System information
System details:
Basically , it's a query params convert issue.
The text was updated successfully, but these errors were encountered: