feat: migrate cli fetch #748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loks0n
commented
Dec 27, 2023
loks0n
commented
- Migrate CLI from axios to fetch
- Refactor commands.js.twig to match patterns from Node and Web templates
|
@loks0n, would you be able to look into why the node tests are failing? |
…o feat-migrate-cli-fetch
| @@ -163,6 +163,7 @@ const commandDescriptions = { | |||
| "locale": `The locale command allows you to customize your app based on your users' location.`, | |||
| "projects": `The projects command allows you to view, create and manage your {{ spec.title|caseUcfirst }} projects.`, | |||
| "storage": `The storage command allows you to manage your project files.`, | |||
| "messaging": `The messaging command allows you to manage and send messages to your users`, | |||
There was a problem hiding this comment.
we have to remove 1.5 related items from here. The fixed CLI needs a release before 1.5
| @@ -6,7 +6,7 @@ const { globalConfig, localConfig } = require("../config"); | |||
| const { actionRunner, success, parseBool, commandDescriptions, log, parse } = require("../parser"); | |||
| {% if sdk.test != "true" %} | |||
| const { questionsLogin } = require("../questions"); | |||
| const { accountCreateEmailSession, accountDeleteSession } = require("./account"); | |||
| const { accountCreateEmailPasswordSession, accountDeleteSession } = require("./account"); | |||
There was a problem hiding this comment.
Is this for 1.5 ? If not lets remove it and change the base branch to main
|
This PR has been refactored to branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.