refactor: billing endpoints

[ArmanNik]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
console-cloud	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 21, 2024 1:16pm
console-preview	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 21, 2024 1:16pm
console-preview-cloud	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 21, 2024 1:16pm

[lohanidamodar]

Left a query. Also where are the similar changes for billingAddresses?

[lohanidamodar]

Where is this method used?

[ArmanNik]

We use this on load to check if there are any expired payments

[lohanidamodar]

We need similar changes applied for billingAddress as well. I don't see those.

[lohanidamodar]

Hey while loading billing address in the organizations billing section, we should always use the endpoint from organization instead from account

I don't yet see that change?

[ArmanNik]

@lohanidamodar there's no change because we only fetch all the addresses never only one.

If there's also a new endpoint for listing addresses, I wasn't informed and it's not mentioned in the linear task either 🤔

[lohanidamodar]

@lohanidamodar there's no change because we only fetch all the addresses never only one.

If there's also a new endpoint for listing addresses, I wasn't informed and it's not mentioned in the linear task either 🤔

How do you display the Organization's assigned billing address? don't you need to fetch the billing address by ID when people are looking at the billing tab for the organization?

[ArmanNik]

@lohanidamodar there's no change because we only fetch all the addresses never only one.
If there's also a new endpoint for listing addresses, I wasn't informed and it's not mentioned in the linear task either 🤔

How do you display the Organization's assigned billing address? don't you need to fetch the billing address by ID when people are looking at the billing tab for the organization?

We are already fetching the addressList when we load the page so I'm just finding it among them

$addressList?.billingAddresses?.find(
        (address) => address.$id === $organization?.billingAddressId
    );

[lohanidamodar]

@lohanidamodar there's no change because we only fetch all the addresses never only one.
If there's also a new endpoint for listing addresses, I wasn't informed and it's not mentioned in the linear task either 🤔

How do you display the Organization's assigned billing address? don't you need to fetch the billing address by ID when people are looking at the billing tab for the organization?

We are already fetching the addressList when we load the page so I'm just finding it among them

$addressList?.billingAddresses?.find(
        (address) => address.$id === $organization?.billingAddressId
    );

As we discussed, lets use the new endpoint through /organizations/billing-addresses/:billingAddressId to fetch the organization's billing address.

[lohanidamodar]

Looks good. However I think this should target cloud branch.