From 374e9fb05f2cc5d33bb9414233ba61547b8bafbc Mon Sep 17 00:00:00 2001
From: Torsten Dittmann <torsten.dittmann@googlemail.com>
Date: Thu, 21 Nov 2024 13:59:29 +0100
Subject: [PATCH 1/4] fix: edit attribute modal safari

---
 .../attributes/edit.svelte                    | 40 +++++++++----------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/src/routes/(console)/project-[project]/databases/database-[database]/collection-[collection]/attributes/edit.svelte b/src/routes/(console)/project-[project]/databases/database-[database]/collection-[collection]/attributes/edit.svelte
index dc8ffbbdd..1676df802 100644
--- a/src/routes/(console)/project-[project]/databases/database-[database]/collection-[collection]/attributes/edit.svelte
+++ b/src/routes/(console)/project-[project]/databases/database-[database]/collection-[collection]/attributes/edit.svelte
@@ -65,19 +65,19 @@
     }
 </script>
 
-{#if selectedAttribute}
-    <Modal {error} size="big" bind:show={showEdit} onSubmit={submit} icon={option?.icon}>
-        <svelte:fragment slot="title">
-            <div class="u-flex u-cross-center u-gap-8">
-                {option?.name}
-                {#if option?.type === 'relationship'}
-                    <div class="tag eyebrow-heading-3">
-                        <span class="text u-x-small">Beta</span>
-                    </div>
-                {/if}
-            </div>
-        </svelte:fragment>
-        <FormList>
+<Modal {error} size="big" bind:show={showEdit} onSubmit={submit} icon={option?.icon}>
+    <svelte:fragment slot="title">
+        <div class="u-flex u-cross-center u-gap-8">
+            {option?.name}
+            {#if option?.type === 'relationship'}
+                <div class="tag eyebrow-heading-3">
+                    <span class="text u-x-small">Beta</span>
+                </div>
+            {/if}
+        </div>
+    </svelte:fragment>
+    <FormList>
+        {#if selectedAttribute}
             {#if selectedAttribute?.type !== 'relationship'}
                 <InputText
                     id="key"
@@ -93,10 +93,10 @@
                     bind:data={selectedAttribute}
                     on:close={() => (option = null)} />
             {/if}
-        </FormList>
-        <svelte:fragment slot="footer">
-            <Button secondary on:click={() => (showEdit = false)}>Cancel</Button>
-            <Button submit disabled={deepEqual(currentAttr, selectedAttribute)}>Update</Button>
-        </svelte:fragment>
-    </Modal>
-{/if}
+        {/if}
+    </FormList>
+    <svelte:fragment slot="footer">
+        <Button secondary on:click={() => (showEdit = false)}>Cancel</Button>
+        <Button submit disabled={deepEqual(currentAttr, selectedAttribute)}>Update</Button>
+    </svelte:fragment>
+</Modal>

From 9f6b180c853c28154288d67068296a8c9e876753 Mon Sep 17 00:00:00 2001
From: Torsten Dittmann <torsten.dittmann@googlemail.com>
Date: Thu, 21 Nov 2024 14:34:46 +0100
Subject: [PATCH 2/4] fix: race conditions on safari for autofocus

---
 src/lib/elements/forms/inputText.svelte | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/lib/elements/forms/inputText.svelte b/src/lib/elements/forms/inputText.svelte
index 0da7f7b38..2c69fa8e4 100644
--- a/src/lib/elements/forms/inputText.svelte
+++ b/src/lib/elements/forms/inputText.svelte
@@ -1,5 +1,5 @@
 <script lang="ts">
-    import { SvelteComponent, onMount } from 'svelte';
+    import { SvelteComponent, onMount, tick } from 'svelte';
     import { FormItem, FormItemPart, Helper, Label } from '.';
     import NullCheckbox from './nullCheckbox.svelte';
     import TextCounter from './textCounter.svelte';
@@ -30,8 +30,9 @@
     let error: string;
     let show = false;
 
-    onMount(() => {
+    onMount(async () => {
         if (element && autofocus) {
+            await tick();
             element.focus();
         }
     });

From 2b4556e655fba819d3798b63d3ae750c4d5a9620 Mon Sep 17 00:00:00 2001
From: Torsten Dittmann <torsten.dittmann@googlemail.com>
Date: Thu, 21 Nov 2024 14:42:11 +0100
Subject: [PATCH 3/4] fix: tests for input

---
 tests/unit/elements/inputText.test.ts | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/unit/elements/inputText.test.ts b/tests/unit/elements/inputText.test.ts
index e2f6f5dff..7592ff654 100644
--- a/tests/unit/elements/inputText.test.ts
+++ b/tests/unit/elements/inputText.test.ts
@@ -2,6 +2,7 @@ import { expect, test } from 'vitest';
 import { render } from '@testing-library/svelte';
 import userEvent from '@testing-library/user-event';
 import { InputText } from '../../../src/lib/elements/forms';
+import { tick } from 'svelte';
 
 test('shows text input', () => {
     const { getByText, getByLabelText } = render(InputText, { id: 'input', label: 'input' });
@@ -24,9 +25,9 @@ test('shows text input - disabled', () => {
     expect(getByLabelText('input')).toBeDisabled();
 });
 
-test('shows text input - autofocus', () => {
+test('shows text input - autofocus', async () => {
     const { getByLabelText } = render(InputText, { id: 'input', label: 'input', autofocus: true });
-
+	await tick();
     expect(getByLabelText('input')).toHaveFocus();
 });
 

From a2141eed3f12aa3d53a430b31659aa520c1d3bb5 Mon Sep 17 00:00:00 2001
From: Torsten Dittmann <torsten.dittmann@googlemail.com>
Date: Thu, 21 Nov 2024 14:43:33 +0100
Subject: [PATCH 4/4] chore: run formatter

---
 tests/unit/elements/inputText.test.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/unit/elements/inputText.test.ts b/tests/unit/elements/inputText.test.ts
index 7592ff654..2c2ef2c6b 100644
--- a/tests/unit/elements/inputText.test.ts
+++ b/tests/unit/elements/inputText.test.ts
@@ -27,7 +27,7 @@ test('shows text input - disabled', () => {
 
 test('shows text input - autofocus', async () => {
     const { getByLabelText } = render(InputText, { id: 'input', label: 'input', autofocus: true });
-	await tick();
+    await tick();
     expect(getByLabelText('input')).toHaveFocus();
 });