Update Mail.php #5495
Update Mail.php #5495
Conversation
| @@ -118,7 +118,7 @@ public function getBody(): string | |||
| */ | |||
| public function setName(string $name): self | |||
| { | |||
| $this->name = $name; | |||
| $this->name = $name ?? ''; | |||
There was a problem hiding this comment.
I don't think this will work because according to the typing on the function, $name is a string and will never be null
|
Please also provide some screenshot as a test that the change fixes the problem. |
|
@stnguyen90 thank you very much! The thing is that I don't have much experience here yet and am just starting this and I thought of just joining open source projects to learn but don't know exactly how to run this locally to test everything properly. Apologies but as soon as I know more I am happy to help on other issues! |
|
@pechtelt1 you would have to start Appwrite and make the necessary API calls to trigger the endpoints. The contributing guide and docs should help you, but do you no longer want to work on this? |
|
@stnguyen90 i will try, thanks! |
|
It wont work for me... i hope someone else will able to fix it! |
|
@pechtelt1, if you cannot make progress on this, can I close it and have someone else work on it? |
|
@stnguyen90 yes thats fine! |
What does this PR do?
Fix the issue
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist